[release/9.0-staging] Fix broken debugger/debuggee startup handshake protocol on macOS26. #118212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jeffschwMSFT
approved these changes
Aug 4, 2025
tommcdon
approved these changes
Aug 4, 2025
jeffschwMSFT
added
Servicing-approved
|
/ba-g space issue unrelated to change |
1 similar comment
|
/ba-g space issue unrelated to change |
|
/ba-g insufficient space error. |
|
Bypassing - build analysis is stuck. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #118120 to release/9.0-staging
/cc @steveisok @lateralusX
Customer Impact
On the MacOS 26, we found the debugger startup handshake using named sempahores are now broken when the debugger and the debuggee are signed with different team id's. This casues the entire VS Code C# debugging experience to be non-functional.
Interestingly, the MacOS release notes only show this being depreicated on iOS. Perhaps this will end up being true on future betas, but I don't think we should hold out any hope.
The fix in this PR uses named pipes first in the handshake and will fall back to the previous implementation if necessary. Mostly on backwards compatibility grounds.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manual before broken / after fixed testing on VSCode.
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.